Skip to content

Fix trigger installation issue #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tekton-robot merged 1 commit into from
Sep 2, 2021
Merged

Fix trigger installation issue #397

tekton-robot merged 1 commit into from
Sep 2, 2021

Conversation

@savitaashture
Copy link
Contributor

@savitaashture savitaashture commented Sep 2, 2021 •
edited
Loading

Changes

Fixes: #396

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 2, 2021
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 2, 2021
@savitaashture
Copy link
Contributor Author

savitaashture commented Sep 2, 2021

/cc @PuneetPunamiya @nikhil-thomas @khrm @vdemeester

@tekton-robot
Copy link
Contributor

tekton-robot commented Sep 2, 2021

@savitaashture: GitHub didn't allow me to request PR reviews from the following users: khrm, PuneetPunamiya.

Note that only tektoncd members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @PuneetPunamiya @nikhil-thomas @khrm @vdemeester

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pradeepitm12
pradeepitm12 reviewed Sep 2, 2021
View reviewed changes
Copy link
Contributor

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2021
vdemeester
vdemeester approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@tekton-robot
Copy link
Contributor

tekton-robot commented Sep 2, 2021

@vdemeester: cat image

Details

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Contributor

tekton-robot commented Sep 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2021
@PuneetPunamiya
Copy link
Member

PuneetPunamiya commented Sep 2, 2021

/lgtm

@tekton-robot
Copy link
Contributor

tekton-robot commented Sep 2, 2021

@PuneetPunamiya: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot merged commit 2ed3f0d into tektoncd:main Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdemeester vdemeester vdemeester approved these changes

@sm43 sm43 Awaiting requested review from sm43

@nikhil-thomas nikhil-thomas Awaiting requested review from nikhil-thomas

+1 more reviewer

@pradeepitm12 pradeepitm12 pradeepitm12 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@pradeepitm12 pradeepitm12

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tekton Triggers is not installing using make apply with latest triggers release v0.16.0

5 participants

@savitaashture @tekton-robot @PuneetPunamiya @vdemeester @pradeepitm12