[OpenShift] Disable quay image replacement #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/M
sm43
force-pushed
the
fix-os-deployment
branch
from
e1bc249 to
01c97e0
Compare
tekton-robot
added
size/L
Contributor
|
The following is the coverage report on the affected files.
|
Currently, we don't have quay images for all versions for pipelines, triggers so `make TARGET=openshift apply` would work with only last build images that is v0.24.3 and v0.14.2. This disable the image replacement so on openshift `make TARGET=openshift apply` will deploy with gcr.io images. Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
sm43
force-pushed
the
fix-os-deployment
branch
from
01c97e0 to
398512a
Compare
Contributor
|
The following is the coverage report on the affected files.
|
Member
|
/approve |
tekton-robot
added
the
approved
tekton-robot
added
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhil-thomas, pradeepitm12, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
/lgtm |
Member
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we don't have quay images for all versions for pipelines,
triggers so
make TARGET=openshift applywould work with onlylast build images that is v0.24.3 and v0.14.2.
This disable the image replacement so on openshift
make TARGET=openshift applywill deploy with gcr.io images.
Signed-off-by: Shivam Mukhade smukhade@redhat.com
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes