Adds Hub UI Component in operator #479

PuneetPunamiya · 2021-10-29T09:03:45Z

This patch adds Hub UI in operator where it deploys
Hub UI

Signed-off-by: Puneet Punamiya ppunamiy@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

tekton-robot · 2021-10-29T09:07:16Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	100.0%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	41.2%
pkg/apis/operator/v1alpha1/tektonhub_types.go	Do not exist	0.0%
pkg/apis/operator/v1alpha1/tektonhub_validation.go	Do not exist	91.7%
pkg/apis/operator/v1alpha1/tektoninstallerset_lifecycle.go	59.3%	56.7%	-2.6
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	80.9%	82.0%	1.1

tekton-robot · 2021-10-29T09:08:34Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	100.0%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	41.2%
pkg/apis/operator/v1alpha1/tektonhub_types.go	Do not exist	0.0%
pkg/apis/operator/v1alpha1/tektonhub_validation.go	Do not exist	91.7%
pkg/apis/operator/v1alpha1/tektoninstallerset_lifecycle.go	59.3%	56.7%	-2.6
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	80.9%	82.0%	1.1

tekton-robot · 2021-10-29T09:38:50Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	100.0%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	41.2%
pkg/apis/operator/v1alpha1/tektonhub_types.go	Do not exist	0.0%
pkg/apis/operator/v1alpha1/tektonhub_validation.go	Do not exist	91.7%
pkg/apis/operator/v1alpha1/tektoninstallerset_lifecycle.go	59.3%	56.7%	-2.6
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	80.9%	82.0%	1.1

PuneetPunamiya · 2021-11-10T06:24:45Z

/retest

tekton-robot · 2022-02-08T12:10:53Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	100.0%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	40.7%
pkg/apis/operator/v1alpha1/tektonhub_types.go	100.0%	33.3%	-66.7
pkg/apis/operator/v1alpha1/tektonhub_validation.go	100.0%	95.5%	-4.5
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	54.7%	58.3%	3.6

PuneetPunamiya · 2022-02-08T12:33:00Z

/test pull-tekton-operator-build-tests

tekton-robot · 2022-02-08T12:36:51Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	100.0%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	40.7%
pkg/apis/operator/v1alpha1/tektonhub_types.go	100.0%	33.3%	-66.7
pkg/apis/operator/v1alpha1/tektonhub_validation.go	100.0%	95.5%	-4.5
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	54.7%	58.3%	3.6

tekton-robot · 2022-02-08T12:54:52Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	100.0%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	40.7%
pkg/apis/operator/v1alpha1/tektonhub_types.go	100.0%	33.3%	-66.7
pkg/apis/operator/v1alpha1/tektonhub_validation.go	100.0%	95.5%	-4.5
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	54.7%	58.3%	3.6

tekton-robot · 2022-02-28T07:25:51Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	76.3%	77.2%	0.9

tekton-robot · 2022-02-28T07:51:51Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	87.5%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	39.3%
pkg/apis/operator/v1alpha1/tektonhub_types.go	100.0%	33.3%	-66.7
pkg/apis/operator/v1alpha1/tektonhub_validation.go	100.0%	93.3%	-6.7
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	76.3%	77.2%	0.9

tekton-robot · 2022-02-28T12:19:23Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_defaults.go	Do not exist	83.3%
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	Do not exist	39.3%
pkg/apis/operator/v1alpha1/tektonhub_types.go	100.0%	33.3%	-66.7
pkg/apis/operator/v1alpha1/tektonhub_validation.go	100.0%	96.2%	-3.8
pkg/reconciler/common/releases.go	41.9%	41.3%	-0.7
pkg/reconciler/kubernetes/tektoninstallerset/install.go	76.3%	77.2%	0.9

PuneetPunamiya · 2022-02-28T12:50:52Z

/test pull-tekton-operator-build-tests

tekton-robot · 2022-03-02T11:15:23Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	39.1%	39.3%	0.2

sm43 · 2022-03-02T11:38:19Z

pkg/reconciler/kubernetes/tektonhub/tektonhub.go

 	dbInstallerSet          = "DbInstallerSet"
 	dbMigrationInstallerSet = "DbMigrationInstallerSet"
 	apiInstallerSet         = "ApiInstallerSet"
+	uiInstallerSet          = "UiInstallerSet"


where are this used?
we should name as HubApiInstallerSet and similar

while storing the name of installer set in tekton hub cr
I think it should be fine keeping it the same because

when we do k get tektonhub hub -oyaml at the end we'll see the following map under hubInstallerSets

hubInstallerSets: ApiInstallerSet: tekton-hub-api-xlnxs DbInstallerSet: tekton-hub-db-pbfpd DbMigrationInstallerSet: tekton-hub-db-migration-9knfw UiInstallerSet: tekton-hub-ui-qfpwp

pkg/reconciler/kubernetes/tektonhub/tektonhub.go

sm43 · 2022-03-02T11:40:41Z

pkg/apis/operator/v1alpha1/tektonhub_types.go

 }

+type UiSpec struct {
+	ApiUrl      string `json:"apiUrl,omitempty"`


can user provide api url?
and operator will use that instead of api it installed?

For now, no user can't provide an api url,
but in future we can add a mechanism for this

pkg/apis/operator/v1alpha1/tektonhub_types.go

pkg/reconciler/kubernetes/tektonhub/tektonhub.go

tekton-robot · 2022-03-02T16:31:23Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	39.1%	39.3%	0.2

PuneetPunamiya · 2022-03-02T18:12:57Z

/test pull-tekton-operator-integration-tests

tekton-robot · 2022-03-03T09:44:55Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	39.1%	39.3%	0.2

tekton-robot · 2022-03-03T10:26:59Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	39.1%	39.3%	0.2

tekton-robot · 2022-03-03T10:34:25Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	39.1%	39.3%	0.2

- This patch adds Hub UI in operator where it deploys Hub UI - Firstly it checks if the value for ui is true or false, in the cr, based on that it creates route in case of openshift and then creates the configMap for ui and installs Hub UI in the default targetNamespace Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>

tekton-robot · 2022-03-03T10:38:26Z

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/operator/v1alpha1/tektonhub_lifecycle.go	39.1%	39.3%	0.2

PuneetPunamiya · 2022-03-03T12:55:14Z

/retest

PuneetPunamiya · 2022-03-03T17:47:06Z

/retest

PuneetPunamiya · 2022-03-03T18:19:43Z

/retest

sm43 · 2022-03-04T07:35:11Z

naming change to be handled in follow up PRs
merging for now
/lgtm

tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 29, 2021

tekton-robot requested review from piyush-garg and sm43 October 29, 2021 09:03

tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 29, 2021

PuneetPunamiya force-pushed the hub-in-operator branch from f273f4d to 3c7c0c9 Compare October 29, 2021 09:05

PuneetPunamiya force-pushed the hub-in-operator branch from 3c7c0c9 to 3af1ea6 Compare October 29, 2021 09:35

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2021

PuneetPunamiya force-pushed the hub-in-operator branch from 3af1ea6 to b9253f6 Compare February 8, 2022 12:08

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2022

PuneetPunamiya force-pushed the hub-in-operator branch from b9253f6 to f5bce55 Compare February 8, 2022 12:34

PuneetPunamiya force-pushed the hub-in-operator branch from f5bce55 to cbec190 Compare February 8, 2022 12:52

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2022

PuneetPunamiya force-pushed the hub-in-operator branch from cbec190 to e0210d8 Compare February 28, 2022 07:23

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2022

PuneetPunamiya changed the title ~~Hub in operator~~ Adds Hub UI Component in operator Feb 28, 2022

PuneetPunamiya force-pushed the hub-in-operator branch from e0210d8 to 450a323 Compare February 28, 2022 07:49

PuneetPunamiya force-pushed the hub-in-operator branch from 450a323 to 107e70c Compare February 28, 2022 12:16

PuneetPunamiya force-pushed the hub-in-operator branch from 107e70c to 7cfbd96 Compare February 28, 2022 13:48

tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 2, 2022

sm43 reviewed Mar 2, 2022

View reviewed changes

pkg/reconciler/kubernetes/tektonhub/tektonhub.go Show resolved Hide resolved

sm43 reviewed Mar 2, 2022

View reviewed changes

pkg/reconciler/kubernetes/tektonhub/tektonhub.go Show resolved Hide resolved

sm43 reviewed Mar 2, 2022

View reviewed changes

pkg/apis/operator/v1alpha1/tektonhub_types.go Outdated Show resolved Hide resolved

sm43 reviewed Mar 2, 2022

View reviewed changes

pkg/apis/operator/v1alpha1/tektonhub_types.go Outdated Show resolved Hide resolved

sm43 reviewed Mar 2, 2022

View reviewed changes

pkg/apis/operator/v1alpha1/tektonhub_types.go Outdated Show resolved Hide resolved

sm43 reviewed Mar 2, 2022

View reviewed changes

pkg/reconciler/kubernetes/tektonhub/tektonhub.go Outdated Show resolved Hide resolved

PuneetPunamiya force-pushed the hub-in-operator branch 2 times, most recently from f865426 to dd30003 Compare March 2, 2022 16:29

PuneetPunamiya force-pushed the hub-in-operator branch from dd30003 to b0f9bec Compare March 3, 2022 09:42

PuneetPunamiya force-pushed the hub-in-operator branch from b0f9bec to 72c422d Compare March 3, 2022 10:24

PuneetPunamiya force-pushed the hub-in-operator branch from 72c422d to 23d9ff6 Compare March 3, 2022 10:32

PuneetPunamiya force-pushed the hub-in-operator branch from 23d9ff6 to 97363a6 Compare March 3, 2022 10:36

tekton-robot assigned sm43 Mar 4, 2022

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2022

tekton-robot merged commit cba3675 into tektoncd:main Mar 4, 2022

Adds Hub UI Component in operator #479

Adds Hub UI Component in operator #479

Uh oh!

Conversation

PuneetPunamiya commented Oct 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Submitter Checklist

Release Notes

Uh oh!

tekton-robot commented Oct 29, 2021

Uh oh!

tekton-robot commented Oct 29, 2021

Uh oh!

tekton-robot commented Oct 29, 2021

Uh oh!

PuneetPunamiya commented Nov 10, 2021

Uh oh!

tekton-robot commented Feb 8, 2022

Uh oh!

PuneetPunamiya commented Feb 8, 2022

Uh oh!

tekton-robot commented Feb 8, 2022

Uh oh!

tekton-robot commented Feb 8, 2022

Uh oh!

tekton-robot commented Feb 28, 2022

Uh oh!

tekton-robot commented Feb 28, 2022

Uh oh!

tekton-robot commented Feb 28, 2022

Uh oh!

PuneetPunamiya commented Feb 28, 2022

Uh oh!

tekton-robot commented Mar 2, 2022

Uh oh!

sm43 Mar 2, 2022

Choose a reason for hiding this comment

Uh oh!

PuneetPunamiya Mar 2, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sm43 Mar 2, 2022

Choose a reason for hiding this comment

Uh oh!

PuneetPunamiya Mar 2, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tekton-robot commented Mar 2, 2022

Uh oh!

PuneetPunamiya commented Mar 2, 2022

Uh oh!

tekton-robot commented Mar 3, 2022

Uh oh!

tekton-robot commented Mar 3, 2022

Uh oh!

tekton-robot commented Mar 3, 2022

Uh oh!

tekton-robot commented Mar 3, 2022

Uh oh!

PuneetPunamiya commented Mar 3, 2022

Uh oh!

PuneetPunamiya commented Mar 3, 2022

Uh oh!

PuneetPunamiya commented Mar 3, 2022

Uh oh!

sm43 commented Mar 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

PuneetPunamiya commented Oct 29, 2021 •

edited

Loading