Fix duplicate InstallerSets in Pipeline Reconciler

[nikhil-thomas]

Fix occurrence of duplicate installerSets in pre, post and main
recociler logic of TektonPipeline reconciler

Adds a label based querying to identify InstallerSets instead of
querying by there name

Use Operator version instead of Component versions while deciding whether to recreate deployments and other resources during upgrades

Signed-off-by: Nikhil Thomas nikthoma@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

fixes duplicate pipeline (pre, post, main)  installerSets occuring in in TektoncdPipeline reconciler. 

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/kubernetes/tektoninstallerset/query.go	Do not exist	83.3%

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/kubernetes/tektoninstallerset/query.go	Do not exist	83.3%

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/kubernetes/tektoninstallerset/query.go	Do not exist	83.3%

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/kubernetes/tektoninstallerset/query.go	Do not exist	83.3%

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/kubernetes/tektoninstallerset/query.go	Do not exist	83.3%

[pradeepitm12]

most of the review comments already addressed 👍
/lgtm

[savitaashture]

Thank you 👍

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [savitaashture]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[PuneetPunamiya]

Can't we read this from the config map ?

[sm43]

yes but the version is already in the env of pod so easier that way
why to do an API call.. :)
also configmap is for other external tools to read the version of operator

[sm43]

Thank you !
/meow

[tekton-robot]

@sm43:

Details

In response to this:

Thank you !
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.