Removes obsolete installersets created during upgrades #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
after the introduction of installerSet, it was observed that multiple installerSet are getting created during upgrades, this adds logic to remove those installeSet. as we have now changed labels on installerSets and query them compared to by their name which we used to save in status. so this deletes any older installerSet which doesn't have the new label of type. Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
tekton-robot
added
the
release-note
tekton-robot
added
the
size/M
Contributor
|
The following is the coverage report on the affected files.
|
concaf
reviewed
Jan 27, 2022
Comment on lines
+57
to
+63
| // CleanUpObsoleteResources cleans up obsolete resources | ||
| // this is required because after TektonInstallerSet were introduced | ||
| // it was observed that during upgrade multiple installerSets were | ||
| // getting created | ||
| // now that we have label based query and we have new labels | ||
| // this cleanup is just to make sure we delete all older installerSets | ||
| // from the cluster |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhil-thomas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Contributor
|
/lgtm |
Contributor
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after the introduction of installerSet, it was observed that
multiple installerSet are getting created during upgrades,
this adds logic to remove those installeSet.
as we have now changed labels on installerSets and query them
compared to by their name which we used to save in status.
so this deletes any older installerSet which doesn't have the
new label of type.
Signed-off-by: Shivam Mukhade smukhade@redhat.com
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes