Skip to content

Conversation

@sm43
Copy link
Member

@sm43 sm43 commented Jan 27, 2022

post pipeline is not getting created on OpenShift, this
fixes it.

Signed-off-by: Shivam Mukhade smukhade@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 27, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 27, 2022
@nikhil-thomas
Copy link
Member

First of all, thank you for catching this 🧑‍💻 👍

could you make a minor change #596 (comment)

post pipeline is not getting created on OpenShift, this
fixes it.

Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
@sm43 sm43 force-pushed the fix-post-pipeline branch from 2770ee2 to 0346f73 Compare January 27, 2022 12:24
@nikhil-thomas
Copy link
Member

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhil-thomas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2022
@tekton-robot tekton-robot merged commit 9597954 into tektoncd:main Jan 27, 2022
@sm43 sm43 deleted the fix-post-pipeline branch August 19, 2022 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants