Skip to content

Conversation

@vdemeester
Copy link
Member

@vdemeester vdemeester commented Feb 7, 2022

Changes

Mainly to be consistent with the rest of the component.

/cc @tektoncd/operator-maintainers

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@tekton-robot tekton-robot requested a review from a team February 7, 2022 17:01
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 7, 2022
@sm43 sm43 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2022
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2022
@sm43 sm43 changed the title Add PACK_VERSION to config.sh file Add PAC_VERSION to config.sh file Feb 8, 2022
@tekton-robot tekton-robot merged commit 247344a into tektoncd:main Feb 8, 2022
@vdemeester vdemeester deleted the pac_version-in-config branch February 8, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants