Improve TekktonInstallerSet Reconciler #620
Conversation
tekton-robot
added
the
release-note
tekton-robot
added
the
size/L
nikhil-thomas
force-pushed
the
fix/webhook-configmap-race
branch
from
7ce712d to
5abba18
Compare
|
The following is the coverage report on the affected files.
|
nikhil-thomas
force-pushed
the
fix/webhook-configmap-race
branch
from
5abba18 to
524d80b
Compare
|
The following is the coverage report on the affected files.
|
| freshCreate = false | ||
| } | ||
|
|
||
| if err := mani.Apply(); err != nil { |
There was a problem hiding this comment.
if we are going to do Apply on all reconcilation
then in allResourcesExists to decide if it is a fresh install
we should check any one resource
checking all resources would be wasting api calls on every reconcilation
There was a problem hiding this comment.
we should check any one resource
the first resource in the list (except namespace)
There was a problem hiding this comment.
it is alright, at max the calls will be issued only once.
ideally, the operaotr should check (issue get calls) for each resource in each reconcile loop.
Add explicit check to ensure that resources are present on cluster after an manifestival.Apply() call Add DeletePropagation policy 'Foreground' to TektonInstallerSet finalizer logic Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
nikhil-thomas
force-pushed
the
fix/webhook-configmap-race
branch
from
524d80b to
d4032a1
Compare
|
The following is the coverage report on the affected files.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
5 participants
Add explicit check to ensure that resources are present on cluster
after an manifestival.Apply() call
Add DeletePropagation policy 'Foreground' to TektonInstallerSet
finalizer logic
Signed-off-by: Nikhil Thomas nikthoma@redhat.com
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes