[OpenShift] Fix RBAC bugs #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/L
nikhil-thomas
force-pushed
the
fix/rbac-management
branch
2 times, most recently
from
02595cf to
0d14f5e
Compare
Member
Author
|
/hold |
tekton-robot
added
the
do-not-merge/hold
nikhil-thomas
force-pushed
the
fix/rbac-management
branch
from
0d14f5e to
0ce6055
Compare
sm43
reviewed
Mar 1, 2022
Member
Author
|
/retest |
vdemeester
reviewed
Mar 1, 2022
Member
Author
|
/retest |
nikhil-thomas
force-pushed
the
fix/rbac-management
branch
2 times, most recently
from
e49aabb to
d9de7e5
Compare
Member
Author
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
Member
|
/lgtm |
vdemeester
approved these changes
Mar 4, 2022
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
- Rename rolebinding created by RBAC reconciler to
'openshift-pipelines-edit' (was 'edit' earlier)
- Add mechanism to ensure that missing RBAC resources are recreated if
the RBAC installerSet is recreated during an upgrade.
- this ensures that RBAC in the version label in RBAC reconciled
namespaces are removed during an upgrade and the presence of RBAC
resources are verified
- Make TektonConfig reconciler listen to TektonInstallerSet events so
that it can recreate RBAC InstallerSet if it is deleted manually from
a cluster
- Add a mechanism to remove ownerReference and 'pipeline' sa subject
from 'edit' rolebinding in namespaces
- This ensures that operator upgrades won't delete/reset 'edit'
rolebinding in usernamespaces.
Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
nikhil-thomas
force-pushed
the
fix/rbac-management
branch
from
d9de7e5 to
86bdf96
Compare
Contributor
|
New changes are detected. LGTM label has been removed. |
Member
|
/test pull-tekton-operator-integration-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nikhil Thomas nikthoma@redhat.com
Changes
Rename rolebinding created by RBAC reconciler to
'openshift-pipelines-edit' (was 'edit' earlier)
Add mechanism to ensure that missing RBAC resources are recreated if
the RBAC installerSet is recreated during an upgrade.
namespaces are removed during an upgrade and the presence of RBAC
resources are re-verified
Make TektonConfig reconciler listen to TektonInstallerSet events so
that it can recreate RBAC InstallerSet if it is deleted manually from
a cluster
Add a mechanism to remove ownerReference and 'pipeline' sa subject
from 'edit' rolebinding in namespaces
rolebinding in usernamespaces.
pipelineserviceaccount.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes