Skip to content

Option to disable community tasks #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tekton-robot merged 1 commit into from
Mar 8, 2022
Merged

Option to disable community tasks #658

tekton-robot merged 1 commit into from
Mar 8, 2022

Conversation

@pradeepitm12
Copy link
Contributor

@pradeepitm12 pradeepitm12 commented Mar 7, 2022 •
edited by nikhil-thomas
Loading

this adds an option to disable installaion of
community cluster tasks.

If community task fetch urls are not reachable, it retries
after 15 minutes of fixed time.
This helps to reduce error logs.

Signed-off-by: Pradeep Kumar pradkuma@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Our communitytasks are tasks maintained in tektoncd/catalog, and when the user is in air-gapped
environment the urls's to fetch them are un-reachable. This leads to huge forbidden error logs.

With this pr user gets an option to disable community tasks from getting installed.
Also if the community tasks are not disabled, and the urls are not reachable. After first error operator
do not try to fetch the urls for 15 minutes.

By default community tasks installation is enabled.
communityClusterTasks: true

spec:
  profile: all
  targetNamespace: openshift-pipelines
  addon:
    params:
    - name: clusterTasks
      value: "true"
    - name: pipelineTemplates
      value: "true"
    - name: communityClusterTasks
      value: "true"

Note: community tasks cannot be true if clustertasks is false.

[openshift] add an option to remove to disable community tasks from getting installed.

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 7, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 7, 2022
@tekton-robot
Copy link
Contributor

tekton-robot commented Mar 7, 2022

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.0% 84.0% -3.0
pkg/reconciler/openshift/tektonaddon/communityClusterTasks.go Do not exist 0.0%

@tekton-robot
Copy link
Contributor

tekton-robot commented Mar 7, 2022

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.0% 84.0% -3.0
pkg/reconciler/openshift/tektonaddon/communityClusterTasks.go Do not exist 0.0%

@tekton-robot
Copy link
Contributor

tekton-robot commented Mar 7, 2022

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.0% 84.0% -3.0
pkg/reconciler/openshift/tektonaddon/communityClusterTasks.go Do not exist 0.0%

nikhil-thomas
nikhil-thomas reviewed Mar 7, 2022
View reviewed changes
@tekton-robot
Copy link
Contributor

tekton-robot commented Mar 7, 2022

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.0% 84.0% -3.0
pkg/reconciler/openshift/tektonaddon/communityClusterTasks.go Do not exist 0.0%

nikhil-thomas
nikhil-thomas reviewed Mar 7, 2022
View reviewed changes
@tekton-robot
Copy link
Contributor

tekton-robot commented Mar 8, 2022

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.0% 84.0% -3.0
pkg/reconciler/openshift/tektonaddon/communityClusterTasks.go Do not exist 0.0%

@tekton-robot
Copy link
Contributor

tekton-robot commented Mar 8, 2022

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.0% 84.0% -3.0
pkg/reconciler/openshift/tektonaddon/communityClusterTasks.go Do not exist 0.0%

@nikhil-thomas
Copy link
Member

nikhil-thomas commented Mar 8, 2022

/approve

@tekton-robot
Copy link
Contributor

tekton-robot commented Mar 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhil-thomas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2022
@nikhil-thomas
Copy link
Member

nikhil-thomas commented Mar 8, 2022

✅ lgtm

@pradeepitm12
Copy link
Contributor Author

pradeepitm12 commented Mar 8, 2022

cc: @sm43

@pradeepitm12
Option to disable community tasks
8597c76 
this adds an option to disable installaion of
community cluster tasks.

If community task fetch urls are not reachable, it retries
after 15 minutes of fixed time.
This helps to reduce error logs.

Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
sm43
sm43 reviewed Mar 8, 2022
View reviewed changes
pkg/reconciler/openshift/tektonaddon/communityClusterTasks.go
@@ -0,0 +1,146 @@
package tektonaddon
Copy link
Member

@sm43 sm43 Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: license

@sm43
Copy link
Member

sm43 commented Mar 8, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2022
@tekton-robot
Copy link
Contributor

tekton-robot commented Mar 8, 2022

The following is the coverage report on the affected files.
Say /test pull-tekton-operator-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/operator/v1alpha1/tektonaddon_validation.go 87.0% 84.0% -3.0
pkg/reconciler/openshift/tektonaddon/communityClusterTasks.go Do not exist 0.0%

@pradeepitm12
Copy link
Contributor Author

pradeepitm12 commented Mar 8, 2022

/test pull-tekton-operator-integration-tests

4 similar comments
@pradeepitm12
Copy link
Contributor Author

pradeepitm12 commented Mar 8, 2022

/test pull-tekton-operator-integration-tests

@pradeepitm12
Copy link
Contributor Author

pradeepitm12 commented Mar 8, 2022

/test pull-tekton-operator-integration-tests

@sm43
Copy link
Member

sm43 commented Mar 8, 2022

/test pull-tekton-operator-integration-tests

@pradeepitm12
Copy link
Contributor Author

pradeepitm12 commented Mar 8, 2022

/test pull-tekton-operator-integration-tests

@tekton-robot tekton-robot merged commit 06d544b into tektoncd:main Mar 8, 2022
@vdemeester vdemeester mentioned this pull request Mar 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@concaf concaf Awaiting requested review from concaf

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

2 more reviewers

@nikhil-thomas nikhil-thomas nikhil-thomas left review comments

@sm43 sm43 sm43 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sm43 sm43

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pradeepitm12 @tekton-robot @nikhil-thomas @sm43