Skip to content

feat(gitea): implement GetTaskURI for remote task resolution#2732

Open
theakshaypant wants to merge 1 commit into
tektoncd:mainfrom
theakshaypant:forgejo/get-task-uri
Open

feat(gitea): implement GetTaskURI for remote task resolution#2732
theakshaypant wants to merge 1 commit into
tektoncd:mainfrom
theakshaypant:forgejo/get-task-uri

Conversation

@theakshaypant
Copy link
Copy Markdown
Member

@theakshaypant theakshaypant commented May 15, 2026

📝 Description of the Change

Enable Gitea/Forgejo provider to resolve remote taskRef URLs using the provider's authenticated API instead of returning "not supported". Supports branch, tag, and commit SHA URL formats.

🔗 Linked GitHub Issue

N/A

🧪 Testing Strategy

  • Unit tests
  • Integration tests
  • End-to-end tests
  • Manual testing
  • Not Applicable

🤖 AI Assistance

AI assistance can be used for various tasks, such as code generation,
documentation, or testing.

Please indicate whether you have used AI assistance
for this PR and provide details if applicable.

  • I have not used any AI assistance for this PR.
  • I have used AI assistance for this PR.

Important

Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.

If the majority of the code in this PR was generated by an AI, please add a Co-authored-by trailer to your commit message.
For example:

Co-authored-by: Claude noreply@anthropic.com

✅ Submitter Checklist

  • 📝 My commit messages are clear, informative, and follow the project's How to write a git commit message guide. The Gitlint linter ensures in CI it's properly validated
  • ✨ I have ensured my commit message prefix (e.g., fix:, feat:) matches the "Type of Change" I selected above.
  • ♽ I have run make test and make lint locally to check for and fix any
    issues. For an efficient workflow, I have considered installing
    pre-commit and running pre-commit install to
    automate these checks.
  • 📖 I have added or updated documentation for any user-facing changes.
  • 🧪 I have added sufficient unit tests for my code changes.
  • 🎁 I have added end-to-end tests where feasible. See README for more details.
  • 🔎 I have addressed any CI test flakiness or provided a clear reason to bypass it.
  • If adding a provider feature, I have filled in the following and updated the provider documentation:
    • GitHub App
    • GitHub Webhook
    • Gitea/Forgejo
    • GitLab
    • Bitbucket Cloud
    • Bitbucket Data Center

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements the GetTaskURI method for the Gitea provider, enabling the retrieval of task files from Gitea and Forgejo URLs. It introduces a splitGiteaURL helper function to extract organization, repository, reference, and path information, supported by new unit tests. Review feedback highlights the need for more robust URL handling by using EscapedPath and PathUnescape to correctly process encoded characters like slashes and plus signs. Additionally, it is recommended to verify the Gitea client's initialization to prevent potential nil pointer panics.

Comment on lines +159 to +162
uriPath := pURL.Path
if pURL.RawPath != "" {
uriPath = pURL.RawPath
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using pURL.Path for splitting is problematic because it is already unescaped by url.Parse. If a path segment (such as a branch name or a directory) contains an encoded slash (%2F), pURL.Path will contain a literal /, causing strings.Split to break the segment incorrectly. Using pURL.EscapedPath() ensures you split only on the intended delimiters.

Suggested change
uriPath := pURL.Path
if pURL.RawPath != "" {
uriPath = pURL.RawPath
}
uriPath := pURL.EscapedPath()

Comment thread pkg/provider/gitea/gitea.go Outdated
Comment thread pkg/provider/gitea/gitea.go
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 15, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 63.15789% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.48%. Comparing base (445941b) to head (070e110).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/provider/gitea/gitea.go 63.15% 14 Missing and 7 partials ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2732      +/-   ##
==========================================
+ Coverage   59.46%   59.48%   +0.01%     
==========================================
  Files         209      209              
  Lines       20702    20757      +55     
==========================================
+ Hits        12311    12347      +36     
- Misses       7616     7628      +12     
- Partials      775      782       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@theakshaypant theakshaypant force-pushed the forgejo/get-task-uri branch from 8c9bdc4 to d4d6bb7 Compare May 20, 2026 05:23
@theakshaypant theakshaypant marked this pull request as ready for review May 20, 2026 05:24
Enable Gitea/Forgejo provider to resolve remote taskRef URLs using
the provider's authenticated API instead of returning "not
supported". Supports branch, tag, and commit SHA URL formats.

Signed-off-by: Akshay Pant <akpant@redhat.com>
Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
@theakshaypant theakshaypant force-pushed the forgejo/get-task-uri branch from d4d6bb7 to 070e110 Compare May 20, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants