Fix local website deployment and update dev docs#643
Merged
tekton-robot merged 1 commit intoMar 28, 2025
Conversation
Following the "Running Natively" guide in the development docs does not work anymore because the `netlify-cli` needs Node v18 or above. The docs were updated to use Node v20. Additionally the setup steps were simplified. The `netlify-cli` has a fixed version in the package.json and is installed via `npm install` as a dev dependency. The dev server can then be started with `npm start`. There is no need to have a global installation of the `netlify-cli` anymore. Issue tektoncd#642. Signed-off-by: Stanislav Jakuschevskij <stas@two-giants.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
Thanks for the PR @twoGiants 😸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Following the "Running Natively" guide in the development docs does not work anymore because the
netlify-clineeds Node v18 or above. The docs were updated to use Node v20.Additionally the setup steps were simplified.
The
netlify-clihas a fixed version in the package.json and is installed vianpm installas a dev dependency. The dev server can then be started withnpm start. There is no need to have a global installation of thenetlify-clianymore.Closes #642.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.