Skip to content

Fix local website deployment and update dev docs#643

Merged
tekton-robot merged 1 commit into
tektoncd:mainfrom
twoGiants:issue-642-fix-running-natively-guide
Mar 28, 2025
Merged

Fix local website deployment and update dev docs#643
tekton-robot merged 1 commit into
tektoncd:mainfrom
twoGiants:issue-642-fix-running-natively-guide

Conversation

@twoGiants
Copy link
Copy Markdown
Member

@twoGiants twoGiants commented Mar 28, 2025

Changes

Following the "Running Natively" guide in the development docs does not work anymore because the netlify-cli needs Node v18 or above. The docs were updated to use Node v20.

Additionally the setup steps were simplified.

The netlify-cli has a fixed version in the package.json and is installed via npm install as a dev dependency. The dev server can then be started with npm start. There is no need to have a global installation of the netlify-cli anymore.

Closes #642.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

Following the "Running Natively" guide in the development docs does not
work anymore because the `netlify-cli` needs Node v18 or above. The docs
were updated to use Node v20.

Additionally the setup steps were simplified.

The `netlify-cli` has a fixed version in the package.json and is
installed via `npm install` as a dev dependency. The dev server can then
be started with `npm start`. There is no need to have a global
installation of the `netlify-cli` anymore.

Issue tektoncd#642.

Signed-off-by: Stanislav Jakuschevskij <stas@two-giants.com>
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 28, 2025
Copy link
Copy Markdown
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tekton-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2025
@AlanGreene
Copy link
Copy Markdown
Member

Thanks for the PR @twoGiants 😸
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2025
@tekton-robot tekton-robot merged commit 4471817 into tektoncd:main Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running website locally following the "Running Natively" guide fails.

4 participants