Enabled option to edit configuration file#163
Merged
nbelzer merged 1 commit intotelevator-apps:masterfrom Jul 31, 2020
Merged
Conversation
cb96dec to
e68651b
Compare
e68651b to
103d034
Compare
|
any updates on this? |
Collaborator
|
Edit I am currently working on getting this functionality in Vimari, please see issue #172 for more information. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Development
First change the way that the settings it's apply to the plugin, instead of having a .js file that create this setting object, the settings are stored in a json file, this is handle by the extension, and sent to the plugin via message. So when the plugin start it will request the settings to the extension.
To be able to change the settings, the first time the user clicks on "Open Configuration File", the ConfigurationModel will look for userSettings.json if isn't there it will create a new one, with the content of defaultSettings.json, and open it TextEdit, if the file already exist it will open it.
Then did some Marie Kondo:
UI Changes
Really enjoy this project, I added recently and every day I use it more and more, I took the time to add an option to update the config file on the go. it was to manage the excluded urls
Closes #153