Skip to content

Enabled option to edit configuration file#163

Merged
nbelzer merged 1 commit intotelevator-apps:masterfrom
nieldm:feature/access_configuration
Jul 31, 2020
Merged

Enabled option to edit configuration file#163
nbelzer merged 1 commit intotelevator-apps:masterfrom
nieldm:feature/access_configuration

Conversation

@nieldm
Copy link
Contributor

@nieldm nieldm commented Dec 15, 2019

Development

First change the way that the settings it's apply to the plugin, instead of having a .js file that create this setting object, the settings are stored in a json file, this is handle by the extension, and sent to the plugin via message. So when the plugin start it will request the settings to the extension.

To be able to change the settings, the first time the user clicks on "Open Configuration File", the ConfigurationModel will look for userSettings.json if isn't there it will create a new one, with the content of defaultSettings.json, and open it TextEdit, if the file already exist it will open it.

Then did some Marie Kondo:

  • Move the constant values to an enum with statics (this add a namespace so it looks more clean), to be more easy to change.
  • Change phew functions to be private (small TOC I have)
  • Added some MARKs

UI Changes

  • Added "Open Configuration File" button
  • Added "Reset Configuration" button
  • And 2 Labels for each

Screen Shot 2019-12-15 at 2 26 20 PM

Really enjoy this project, I added recently and every day I use it more and more, I took the time to add an option to update the config file on the go. it was to manage the excluded urls

Closes #153

@nieldm nieldm force-pushed the feature/access_configuration branch from cb96dec to e68651b Compare December 16, 2019 20:34
@nieldm nieldm force-pushed the feature/access_configuration branch from e68651b to 103d034 Compare December 16, 2019 20:37
@sebastianzillessen
Copy link

any updates on this?

@nbelzer
Copy link
Collaborator

nbelzer commented Mar 20, 2020

@sebastianzillessen I'm continuing the work of @nieldm on my own fork which you can check out here. You can try it out locally, make sure to check out the feature/access_configuration branch.

Edit I am currently working on getting this functionality in Vimari, please see issue #172 for more information.

@nbelzer nbelzer mentioned this pull request Jul 25, 2020
@nbelzer nbelzer merged commit 808d53a into televator-apps:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Excluded URLs

3 participants