Added fix for if no request body or parameters#16
Merged
brendo merged 2 commits intotemando:masterfrom Jan 18, 2018
Merged
Conversation
Contributor
|
This PR is fine, but the bump of jst has caused an error in CI. It's actually an error with the types of jst, so I've raised a PR jdwije/jst#8 to resolve. Once that lands, this PR can be accepted as is (and we'll do the update), or the PR can bump the dependency to |
Closed
|
This PR introduced a bug which I detailed in issue #32 . The added if statements are checking the wrong object. They should be checking the documentationConfig, not the operationObj. The way this PR changed things, it totally ignores request bodies and path parameters |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.