Remote vs Local cluster and docker configuration options#32
Remote vs Local cluster and docker configuration options#32smittyweygant wants to merge 1 commit intomainfrom
Conversation
- Start up options to run Background Checks with different Temporal Cluster configurations
- Run Background Checks in its own Docker Compose environment (allows for use of existing Temporal docker compose)
- Background Checks connects to a Remote Temporal server
- One Docker Compose for Background Checks + Temporal (legacy)
- mTLS configuration embedded in Docker .env.mtls
|
smittyweygant seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
| @@ -0,0 +1,10 @@ | |||
| # Update the following entries to point to your environment | |||
| TEMPORAL_WEB_UI_URL=https://web.smitty.temporal-dev.tmprl.cloud | |||
There was a problem hiding this comment.
Maybe use web.acme.temporal-dev... or similar?
| POSTGRES_USER: temporal | ||
| image: postgres:13 | ||
| ports: | ||
| - 5432:5432 |
There was a problem hiding this comment.
This doesn't need to be exposed, it will either be hit by the in-docker-compose Temporal where the container network can be used or it won't be run at all.
| command: -invite-jim | ||
| ports: | ||
| - 8025:8025 | ||
| - 1025:1025 |
There was a problem hiding this comment.
This doesn't need to be exposed. It will only hit over the container network from workers.
| if [ $withtemporal == "true" ]; then | ||
| echo "Starting up Temporal and Background Check app together" | ||
| docker compose --profile withtemporal up --build -d | ||
| elif [ $withtemporal == "false" ]; then |
| echo "Starting up Background Check app to point to existing local Temporal endpoint" | ||
| docker compose up --build -d | ||
| fi | ||
| elif [ $local == "false" ]; then |
| ) | ||
|
|
||
| var ( | ||
| // mTLS Certificates - copied from project /secrets to container /run/secrets during Docker build |
There was a problem hiding this comment.
They aren't copied during build, they are mounted at container runtime.
|
|
||
| return client.NewClient(options) | ||
| } | ||
|
|
There was a problem hiding this comment.
Please remove the comment block now the code is in place.
| @@ -0,0 +1,6 @@ | |||
| TEMPORAL_WEB_UI_URL=http://localhost:8088 | |||
| TEMPORAL_CLI_ADDRESS=host.docker.internal:7233 | |||
There was a problem hiding this comment.
Why is the host.docker.internal hostname being used here rather than just temporal?
| .DS_Store | ||
| test | ||
| test.log | ||
| secrets/*.key |
There was a problem hiding this comment.
I'd just add secrets/*
| echo "Local environment:" $local | ||
| echo "With Temporal Server:" $withtemporal | ||
|
|
||
| if [ $local == "true" ]; then |
There was a problem hiding this comment.
I think this block would be more succinct if you build variables with strings like "" or "--profile withtemporal" and then interpolate those into a single docker compose ... command at the end.
3 participants
What was changed
Why?
Enable demos of Temporal Cloud
Enable "toggling" of environments
Modularize the deployment of the Background Check App so it can be managed separately from Temporal Cluster