Print CustomSearchAttributeAliases as part of namespace description #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hehaifengcn
commented
May 23, 2025
| "ReplicationConfig.Clusters", "Config.HistoryArchivalState", "Config.VisibilityArchivalState", | ||
| "IsGlobalNamespace", "FailoverVersion", "FailoverHistory", "Config.HistoryArchivalUri", | ||
| "Config.VisibilityArchivalUri", | ||
| "Config.CustomSearchAttributeAliases", |
Contributor
Author
There was a problem hiding this comment.
this will show CustomSearchAttributeAliases by default. Can put it behind of flag if ppl really want to.
cretz
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
CustomSearchAttributeAliases is used when Temporal server is configured with search attribute mapper which maps external name (customer provided) to internal name. In such case, internal names are encoded in workflow execution instead of external ones. Normally customer don't care about such mapping. However, if we want to replicate a workflow using custom search attribute between two servers, we want to make sure CustomSearchAttributeAliases is configured the same between the two. In the context of self-hosted to cloud namespace migration, customer can provide their CustomSearchAttributeAliases configuration with this command.
Checklist
Closes
How was this tested: