Skip to content

Conversation

@roxblnfk
Copy link
Contributor

@roxblnfk roxblnfk commented Nov 8, 2024

What does this PR do?

The documentation for the PHP SDK client has been corrected and updated.

@roxblnfk roxblnfk requested a review from a team as a code owner November 8, 2024 08:33
@napcs napcs added the community-contributor This PR was submitted external to Temporal label Nov 19, 2024
@fairlydurable fairlydurable changed the title [PHP] Improve docs about client EDU-3582: [PHP] Improve docs about client Nov 21, 2024
@fairlydurable fairlydurable changed the title EDU-3582: [PHP] Improve docs about client EDU-3508: [PHP] Improve docs about client Nov 21, 2024
Copy link
Contributor

@brianmacdonald-temporal brianmacdonald-temporal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me.

@brianmacdonald-temporal brianmacdonald-temporal merged commit f7baaea into temporalio:main Dec 4, 2024
1 check passed
@roxblnfk roxblnfk deleted the php-client branch December 5, 2024 14:55
stephanos pushed a commit to stephanos/documentation that referenced this pull request Dec 9, 2024
* Improve docs about client connection configuration

* PHP Client: add section `Advanced connection options`

* Describe RPC timeout

* Update index

* Add info about configuring RoadRunner to connect to Temporal Cloud

---------

Co-authored-by: Brian MacDonald <brian.macdonald@temporal.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contributor This PR was submitted external to Temporal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants