Add custom annotation sample #734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quinn-With-Two-Ns
force-pushed
the
custom-annotation-sample
branch
from
87e57ae to
fe24ae8
Compare
Quinn-With-Two-Ns
requested review from
a team,
antmendoza and
tsurdilo
as code owners
cretz
reviewed
Jun 25, 2025
| public static class ActivityInboundCallsInterceptorAnnotation | ||
| extends io.temporal.common.interceptors.ActivityInboundCallsInterceptorBase { | ||
| private final ActivityInboundCallsInterceptor next; | ||
| private Set<Class<? extends Exception>> benignExceptionTypes = new HashSet<>(); |
Member
There was a problem hiding this comment.
Pedantic, can ignore
Suggested change
| private Set<Class<? extends Exception>> benignExceptionTypes = new HashSet<>(); | |
| private Set<Class<? extends Exception>> benignExceptionTypes = Collections.emptySet<>(); |
Comment on lines
+90
to
+92
| if (benignExceptionTypes.isEmpty()) { | ||
| return next.execute(input); | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if (benignExceptionTypes.isEmpty()) { | |
| return next.execute(input); | |
| } |
Pedantic, but probably no value in this extra code
Contributor
Author
There was a problem hiding this comment.
Nothing really to show in the tests here
Member
There was a problem hiding this comment.
Just to prove the interceptor code even works (and continues to). We have had issues in other SDK samples repos where our lack of tests have caused us to miss when someone broke something, and we only found out when a human user manually tried to run the sample again. But up to you, non-blocking.
cretz
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a sample showing how to create a custom annotation to customize activity type.