Fix polling sample 2 #152
Merged
Fix polling sample 2 #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
force-pushed
the
fix-polling-sample-2
branch
from
84a4a82 to
ddd7b83
Compare
cretz
approved these changes
Nov 25, 2024
Member
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
LGTM but may want to wait on @drewhoskins. As for CI failure, just changing macos-12 to macos-13 should fix it, feel free to do inside this PR, doesn't necessarily have to be a separate one.
drewhoskins-temporal
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor modification of #150. Use a global variable to separate implementation details from the user-facing lesson.