[fetch-esm] Address CI flakes and Node warning messages #442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
On the
fetch-esmsample:tsxinstead ofts-node..tsfile extensions in import directives instead of.js.Why
fetch-esmsample makes HTTP requests to httpbin.org, which is sometimes slow or flaky. This is rippling down on thetemporalio/sdk-typescriptrepo, as thefetch-esmsample is run as part oftemporalio/sdk-typescript's CI tests to validate that the SDK can be used with ESM projects.ts-nodelibrary has not seen a commit in more than two years and is no longer aligned with latest releases of Node. This has been causing warning messages when running thefetch-esmsample. Switching totsxresolves these warnings.