Skip to content

Conversation

@petrkoutnycz
Copy link
Contributor

What was changed

Marked Activity for workflow completion as erroneous.

Why?

So a developer might see the activity to be failed in observability tool, recording event with exception is not enough. At least not in our case with New Relic.

@petrkoutnycz petrkoutnycz requested a review from cretz May 29, 2024 18:40
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cretz cretz merged commit 1f6676b into temporalio:main May 29, 2024
@petrkoutnycz petrkoutnycz deleted the feature/otel-set-error-on-exception branch July 1, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants