HTTP CONNECT proxy support #318
Conversation
|
|
adeal
force-pushed
the
dev/adeal/feature_http_connect_proxy
branch
from
9a12e56 to
536f2ea
Compare
| const struct ClientTlsOptions *tls_options; | ||
| const struct ClientRetryOptions *retry_options; | ||
| const struct ClientKeepAliveOptions *keep_alive_options; | ||
| const HttpConnectProxyOptions *http_connect_proxy_options; |
There was a problem hiding this comment.
This is auto-generated as part of the Rust build and therefore should match the Rust constructs
There was a problem hiding this comment.
I'm getting an inconsistent experience, but this is ultimately what is gen'd locally for me.
There was a problem hiding this comment.
No prob, I may have just assumed it was going to generate const struct. If CI passes w/ what is generated here we're all good. Can ignore.
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
Everything looks good. I think CI is failing because of the line endings of the Interop.cs file maybe? Unsure, I will try to look shortly (and may try out via merge to your fork branch if that's ok), but everything in this PR in general LGTM.
|
There was an issue where the FFI struct referenced |
AH, obvious in hindsight. Thanks for tracking it down and making the fix. |
3 participants
What was changed
This change adds HTTP CONNECT proxy support.
Temporalio.Client.HttpConnectProxyConfigWhy?
Checklist
Closes [Feature Request] HTTP CONNECT proxy support #215
How was this tested:
This is challenging to test w/o a local proxy setup, but I'm open to recommendations. If I'm able, I'll publish a local release and see if I can test this against an environment where proxy resources exist.
Any docs updates needed?