Skip to content

Do not warn about leftover handlers on workflow failure #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cretz merged 1 commit into from
Aug 9, 2024
Merged

Do not warn about leftover handlers on workflow failure #329

cretz merged 1 commit into from
Aug 9, 2024

Conversation

@cretz
Copy link
Member

@cretz cretz commented Aug 9, 2024

What was changed

Only warn if first completion is a non-failure

Checklist

  1. Closes [Feature Request] Do not warn on unfinished handler on workflow failure #325

@cretz cretz requested a review from a team August 9, 2024 15:30
@cretz cretz merged commit efdb9a0 into temporalio:main Aug 9, 2024
@cretz cretz deleted the handler-nowarn-failure branch August 9, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request] Do not warn on unfinished handler on workflow failure

2 participants

@cretz @Sushisource