Update with start #381
Update with start #381
Conversation
| } | ||
|
|
||
| using (var activity = ClientSource.StartActivity( | ||
| $"UpdateWithStartWorkflow:{input.Options.StartWorkflowOperation.Workflow}", |
There was a problem hiding this comment.
@dandavison - note this differs from Go. In Go, this is UpdateWithStartWorkflow:<update-name> whereas here it is UpdateWithStartWorkflow:<workflow-name>. This latter behavior matches signal with start in both SDKs (i.e. it's SignalWithStartWorkflow:<workflow-name> not SignalWithStartWorkflow:<signal-name>), and of course inbound update does get its own span worker side. Not sure we even properly set tracing in any other update-with-start SDK.
dandavison
left a comment
dandavison
left a comment
There was a problem hiding this comment.
LGTM, I didn't see anything missing or out of line with the plan.
| string id, string? runId = null, string? firstExecutionRunId = null); | ||
|
|
||
| /// <summary> | ||
| /// Start an update via a call to a WorkflowUpdate attributed method, possibly starting the |
There was a problem hiding this comment.
"via a call to a WorkflowUpdate attributed method" means "this will end up causing an update handler method to be executed in a workflow"?
There was a problem hiding this comment.
Not exactly. What "via a call" means is that this is a lambda expression that makes a call to a method with the WorkflowUpdate attribute. So it looks like myClient.StartUpdateWithStartWorkflow((MyWorkflow wf) => wf.MyUpdateMethodWithAttribute(myArg), ....
2 participants
What was changed
Added
StartUpdateWithStartWorkflowAsyncandExecuteUpdateWithStartWorkflowAsyncclient calls and all that entails. Marked as experimental.Checklist