Skip to content

Add advanced signal-handling tests #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cretz merged 1 commit into from
Feb 28, 2025
Merged

Add advanced signal-handling tests #418

cretz merged 1 commit into from
Feb 28, 2025

Conversation

@cretz
Copy link
Member

@cretz cretz commented Feb 27, 2025

What was changed

For peace of mind because there was some concern it wasn't being done properly added the following two tests:

  • Confirm signals that occur in the same task and before start are received before main method runs
  • Confirm unhandled command signals are received as expected

Checklist

  1. Closes [Feature Request] Add tests/confirm signal handlers run first and as expected #406

@cretz cretz requested a review from a team February 27, 2025 22:35
@cretz cretz merged commit bbbfad1 into temporalio:main Feb 28, 2025
8 checks passed
@cretz cretz deleted the signal-handler-tests branch February 28, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request] Add tests/confirm signal handlers run first and as expected

2 participants

@cretz @Sushisource