Fail the workflow task if a requested local activity is not registered #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…ionException to fail task, not workflow
cretz
reviewed
May 8, 2025
Member
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
LGTM, very minor things. Only blocking thing is what to do when there is no activity worker.
cretz
approved these changes
May 8, 2025
Member
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
Only non-blocking things. Update them if you'd like or not, then feel free to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Executing an unregistered local activity will fail the workflow task rather than just the activity.
Why?
Reduces unhelpful retries.
Checklist
Closes 463
How was this tested:
New unit test added to WorkflowWorkerTests
Any docs updates needed?
None