Added Category to ApplicationFailureException #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cretz
approved these changes
May 28, 2025
Member
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
Looks great! Looks like there may be some failure with the .NET SDK tests in https://github.com/temporalio/features? Also, looks like you may have to click/sign the CLA (not sure why it didn't take it from other places).
cretz
reviewed
May 28, 2025
| IReadOnlyCollection<object?>? details = null, | ||
| TimeSpan? nextRetryDelay = null) | ||
| TimeSpan? nextRetryDelay = null, | ||
| ApplicationErrorCategory category = ApplicationErrorCategory.Unspecified) |
Member
There was a problem hiding this comment.
Ok, something strange is happening with feature tests where it's getting:
System.MissingMethodException: Method not found: 'Void Temporalio.Exceptions.ApplicationFailureException..ctor(System.String, System.String, Boolean, System.Collections.Generic.IReadOnlyCollection`1<System.Object>, System.Nullable`1<System.TimeSpan>)'.
at activity.cancel_try_cancel.Feature.MyWorkflow.RunAsync()
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
at activity.cancel_try_cancel.Feature.MyWorkflow.RunAsync()
at InvokeStub_MyWorkflow.RunAsync(Object, Object, IntPtr*)
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr) --- End of stack trace from previous location ---
at Temporalio.Worker.WorkflowInstance.InboundImpl.ExecuteWorkflowAsync(ExecuteWorkflowInput input) in /home/runner/work/sdk-dotnet/sdk-dotnet/sdk-dotnet/src/Temporalio/Worker/WorkflowInstance.cs:line 1809
at Temporalio.Worker.WorkflowInstance.<InitializeWorkflow>b__180_1() in /home/runner/work/sdk-dotnet/sdk-dotnet/sdk-dotnet/src/Temporalio/Worker/WorkflowInstance.cs:line 1551
at Temporalio.Worker.WorkflowInstance.RunTopLevelAsync(Func`1 func) in /home/runner/work/sdk-dotnet/sdk-dotnet/sdk-dotnet/src/Temporalio/Worker/WorkflowInstance.cs:line 956
at Temporalio.Worker.WorkflowInstance.RunOnce(Boolean checkConditions) in /home/runner/work/sdk-dotnet/sdk-dotnet/sdk-dotnet/src/Temporalio/Worker/WorkflowInstance.cs:line 845
at Temporalio.Worker.WorkflowInstance.Activate(WorkflowActivation act) in /home/runner/work/sdk-dotnet/sdk-dotnet/sdk-dotnet/src/Temporalio/Worker/WorkflowInstance.cs:line 691Something strange is happening here where the feature test is compiled against an older .NET SDK version than it is running against. That may have to be investigated unfortunately and may even have to update https://github.com/temporalio/features/blob/main/sdkbuild/dotnet.go if somehow it is compiling against the same version it is running against.
Contributor
Author
|
CI failure fix PR submitted: temporalio/features#628 |
maciejdudko
force-pushed
the
application-error-category
branch
from
ab26dfe to
2f2081d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added
Categoryfield toApplicationFailureException.Why?
Feature request: temporalio/features#614
Checklist
Closes [Feature Request] Apply application failure logging and metrics behaviour according to
ApplicationErrorCategory#448How was this tested: Added test
GetResultAsync_BenignFailure_Throws