Updated sdk-core to latest #485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Jun 5, 2025
Member
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
LGTM, but looks like one test at ExecuteWorkflowAsync_PollingBehavior_Autoscaling may be flaky.
You also may need to regenerate protos (that fails a CI check we have only in the Windows run) since new ones came over in the submodule. See https://github.com/temporalio/sdk-dotnet?tab=readme-ov-file#regenerating-protos. Unsure if there are other aspects that need to be added (e.g. any new client calls).
maciejdudko
force-pushed
the
sdk-core-update
branch
from
9a1021f to
800bff3
Compare
Sushisource
approved these changes
Jun 6, 2025
Member
Sushisource
left a comment
Sushisource
left a comment
There was a problem hiding this comment.
May be worth checking out that flake per Chad's suggestion. I think that might be a matter of just adjusting the test to use an eventually assert, because these counts are timing sensitive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Updated
sdk-coresubmodule to latest upstream commit temporalio/sdk-core@8913cdbThe update broke Workflow Replayer due to bad poller behavior config, the config was fixed.