💥 BREAKING - Make static summary/details lazy on workflow description #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejdudko
approved these changes
Jun 6, 2025
| RawDescription = rawDescription; | ||
| StaticSummary = staticSummary; | ||
| StaticDetails = staticDetails; | ||
| #pragma warning disable VSTHRD011 // This should not be able to deadlock |
Contributor
There was a problem hiding this comment.
This is almost certainly safe but I'd still explore changing it to AsyncLazy sometime in the future.
Member
Author
There was a problem hiding this comment.
The concern there is https://learn.microsoft.com/en-us/dotnet/api/microsoft.visualstudio.threading.asynclazy-1?view=visualstudiosdk-2019 requires a dependency we don't really want to take. But we could make our own if we had to.
There was a problem hiding this comment.
take Stephen implementation: https://devblogs.microsoft.com/dotnet/asynclazyt/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Changed
WorkflowExecutionDescriptionproperties ofStaticSummaryandStaticDetailsto now be methods ofGetStaticSummaryAsyncandGetStaticDetailsAsync. This is a breaking change to experimental API.Checklist