Fix issue where child workflow starts and completes in same activation #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaroslaw-korecki
approved these changes
Jun 30, 2025
maciejdudko
approved these changes
Jun 30, 2025
|
Hello, is this fixing the following problem?
|
Member
Author
|
It may fix that problem in rare cases if child workflow initiated and child workflow completed events are in the same task. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
There was an issue where, when a child start and a child resolve came in the same activation, the resolve had no pending child to work with because the start code doesn't run to transfer its state to pending resolve.
Changed code to only have one container of pending children and not differentiate waiting for start vs waiting for result. This should have no backwards incompatibilities that I can see. Reviewers may want to "hide whitespace" to see what changed more clearly.