Add defaults for Poller automation #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
reviewed
Jun 26, 2025
| /// </summary> | ||
| /// <param name="maximum">The maximum number of pollers at a time.</param> | ||
| public SimpleMaximum(int maximum) | ||
| public SimpleMaximum(int maximum = 5) |
Member
There was a problem hiding this comment.
Let's leave this one no-default I think, since if they're explicitly setting simple max, they pretty clearly intend to change the default.
Sushisource
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add in defaults to PollerBehavior constructors
Why?
To match python, https://github.com/temporalio/sdk-python/pull/830/files#diff-71bb79f8f6f7277331d9df6e0c1de02a9b08a91977289ddf876398e8ad5a8d53
Checklist
Closes
How was this tested: