Wrap GRPC::CANCELED and DEADLINE_EXCEEDED in new exception type#2172
Merged
Quinn-With-Two-Ns merged 4 commits intotemporalio:masterfrom Aug 6, 2024
Merged
Wrap GRPC::CANCELED and DEADLINE_EXCEEDED in new exception type#2172Quinn-With-Two-Ns merged 4 commits intotemporalio:masterfrom
Quinn-With-Two-Ns merged 4 commits intotemporalio:masterfrom
Conversation
cretz
approved these changes
Aug 6, 2024
| * this is only related to the client call itself. | ||
| */ | ||
| public class WorkflowUpdateTimeoutOrCancelledException extends WorkflowServiceException { | ||
| public WorkflowUpdateTimeoutOrCancelledException( |
Member
There was a problem hiding this comment.
May be worth docs here stating this constructor is for internal use only and that the parameters may not be stable, but maybe not if we never expect to change or we can overload
Contributor
Author
There was a problem hiding this comment.
I think it is fine as is, we do the same thing for all the other children of WorkflowServiceException. A user may construct it for mocking/testsing
Member
There was a problem hiding this comment.
Yeah, my only concern is that we can't ever change it now, only overload it. But no big deal.
Quinn-With-Two-Ns
force-pushed
the
issue-2069
branch
from
bce10e5 to
4eecd33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap GRPC::CANCELED and DEADLINE_EXCEEDED in new exception type
WorkflowUpdateTimeoutOrCancelledExceptioncloses #2069