Skip to content

Expose ShouldContinueAsNew and HistorySize #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
roxblnfk merged 7 commits into from
Aug 6, 2024
Merged

Expose ShouldContinueAsNew and HistorySize #475

roxblnfk merged 7 commits into from
Aug 6, 2024

Conversation

@roxblnfk
Copy link
Collaborator

@roxblnfk roxblnfk commented Jul 16, 2024 •
edited
Loading

What was changed

Separated Server's and Client's requests and responses.
Added new flags mapping:

  • ShouldContinueAsNew
  • HistorySize
// Workflow Context
Workflow::getInfo()->historySize;
Workflow::getInfo()->shouldContinueAsNew;

Checklist

  1. Closes Expose shouldContinueAsNew in WorkflowInfo #440

@vercel
Copy link

vercel bot commented Jul 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
php ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 0:10am

@roxblnfk roxblnfk marked this pull request as draft July 16, 2024 15:15
@roxblnfk roxblnfk marked this pull request as ready for review August 6, 2024 12:41
@roxblnfk roxblnfk requested review from Sushisource and wolfy-j August 6, 2024 12:41
@roxblnfk roxblnfk merged commit 4296cfb into master Aug 6, 2024
@roxblnfk roxblnfk deleted the continue-as-new-suggested branch August 6, 2024 13:01
@roxblnfk roxblnfk mentioned this pull request Oct 17, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfy-j wolfy-j wolfy-j approved these changes

@Sushisource Sushisource Awaiting requested review from Sushisource

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose shouldContinueAsNew in WorkflowInfo

3 participants

@roxblnfk @wolfy-j