Skip to content

Conversation

@roxblnfk
Copy link
Collaborator

@roxblnfk roxblnfk commented Aug 12, 2024

What was changed

Added the new method Workflow::allHandlersFinished()

yield Workflow::await(
    static fn() => Workflow::allHandlersFinished(),
);

Added HandlerUnfinishedPolicy enum

Checklist

  1. Closes Provide a method to wait for handlers to finish #447
  2. How was this tested: added autotest
  3. Any docs updates needed?

@vercel
Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
php ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 4:20pm

Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes good sense to me. We might at some point in the future want to provide a getAllRunningHandlers type of API that will return a list of things like handler name, etc, but I don't see anything here preventing us adding that later.

@roxblnfk roxblnfk merged commit a1c5edf into master Aug 13, 2024
@roxblnfk roxblnfk deleted the wait-for-handler-executions branch August 13, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide a method to wait for handlers to finish

4 participants