This repository was archived by the owner on Oct 9, 2025. It is now read-only.
fix address panic when $HOME environment is not defined#41
Open
r-mol wants to merge 2 commits intotemporalio:mainfrom
Open
fix address panic when $HOME environment is not defined#41r-mol wants to merge 2 commits intotemporalio:mainfrom
r-mol wants to merge 2 commits intotemporalio:mainfrom
Conversation
Сhanged the test because it didn't pass if the .config directory wasn't created before the test was run.
1. os.UserHomeDir() returns an error only when $HOME environment is not set. Therefore, instead of returning an error, the dir variable is set to a temporary directory (using the os.TempDir() function), this helps to avoid address panic in the future. 2. Added a test to check when environment $HOME is not set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
pkg/config/config.go ->
os.UserHomeDir() returns an error only when $HOME environment is not set. Therefore, instead of returning an error, the dir variable is set to a temporary directory (using the os.TempDir() function), this helps to avoid address panic in the future.
pkg/config/config_test.go ->
Why?
I was getting address panic after trying to create a new TCTL config. This was happening because environment $HOME was not set.
Checklist