Prioritize UI/tctl when system is throttled#4623
Merged
pdoerner merged 11 commits intotemporalio:masterfrom Jul 18, 2023
Merged
Prioritize UI/tctl when system is throttled#4623pdoerner merged 11 commits intotemporalio:masterfrom
pdoerner merged 11 commits intotemporalio:masterfrom
Conversation
yycptt
reviewed
Jul 14, 2023
Member
yycptt
left a comment
There was a problem hiding this comment.
Can you double check if visibility persistence client has any rate limiter? If so that probably should also be updated.
yycptt
approved these changes
Jul 17, 2023
Member
yycptt
left a comment
There was a problem hiding this comment.
Overall LGTM. Please land after addressing the comments.
common/persistence/visibility/visibility_manager_rate_limited.go
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
caller-typeheader:operatoroperatorrequestsWhy?
When the system is being throttled, users would like to be able to debug using the web UI and/or tctl without running into rate limit errors
How did you test it?
New unit tests
Potential risks
The operator RPS is set too low leading to new rate limit errors
Is hotfix candidate?
No