Change RunIDs to use UUIDv7 #6933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
reviewed
Dec 4, 2024
tdeebswihart
force-pushed
the
tds/uuidv7-runid
branch
from
b8710c0 to
3a8e5b3
Compare
yycptt
approved these changes
Dec 5, 2024
| // It returns the creationContext which can later be used to insert into the executions table. | ||
| func (s *Starter) prepareNewWorkflow(workflowID string) (*creationParams, error) { | ||
| runID := uuid.NewString() | ||
| runUUID, err := uuid.NewV7() |
Member
There was a problem hiding this comment.
shall we use primitives.NewUUID() then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I changed our RunID generation to use UUIDv7 instead of V4 by default.
Why?
UUIDv7s have a timestamp as their prefix, which will help us optimize the physical storage layout of our workflow-related data.
How did you test it?
Existing tests
Potential risks
I don't believe there are any
Documentation
Not necessary.
Is hotfix candidate?
No