-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add support for standalone activity termination #8665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
111 commits
Select commit
Hold shift + click to select a range
f8ccafb
PollComponent and PollActivityExecution
dandavison 46eb18e
Changes from @fretz12's review
dandavison 11cac65
Edit docstrings
dandavison 11c6b59
Non-error response on long-poll timeout
dandavison b24a022
Remove unused opts parameter of PollComponent
dandavison 0db9858
Error on runID mismatch
dandavison c888969
Revert comment
dandavison 5740320
Use framework-provided predicate to wait for any state change
dandavison 1d27df4
Address code review comments
dandavison 1107a99
Use component last updated VT
dandavison 2ee2b75
Cleanup
dandavison ea12fcc
Refactor
dandavison 5c2c41e
Refcator: combine handlers
dandavison c02c869
Rename: ComponentStateToken
dandavison e1a52d4
entity -> execution
dandavison 24ef87c
Rename: ref.componentVT
dandavison 5412f7e
Subscribe to notifications at component level, not execution level
dandavison 612426f
Revert "Subscribe to notifications at component level, not execution …
dandavison 7958efd
Add non-functional test
dandavison 3904355
Add tests of cross-component subscribe/notify
dandavison 00ef0ff
Rename: ComponentStateChanged
dandavison da60095
Revert to using ref as long-poll token
dandavison 6d5fc28
Rename: ChasmExecutionNotification
dandavison a604d80
Functional test env
dandavison 6917450
DEBUG
dandavison 27aafa7
TestStartToClose
dandavison c623906
ScheduleToStart timeout
dandavison e05af5a
Revert "ScheduleToStart timeout"
dandavison 6bd6d57
Evolve test
dandavison f325df8
Evolve test
dandavison 099e6da
Fix expectation
dandavison 7b23898
Revert "DEBUG"
dandavison b120e9c
PS
dandavison 7e67862
Fix timeout code
dandavison 055044f
Update test
dandavison affc857
TEMP: eliminate buffer
dandavison fa4e0ea
PS
dandavison f6c5290
WIP: transactionImpl
dandavison b540eb0
Revert "WIP: transactionImpl"
dandavison d1045de
Fix test
dandavison f48a2b8
Do not notify from UpdateComponent
dandavison c98c8f9
Wire through chasm notification to history engine
dandavison 18159b6
Change signature
dandavison c4a0f1a
Send notification from MS transaction layer
dandavison 310ae97
Update test
dandavison 4ca1d33
Don't send ref in chasm execution notification
dandavison ccd63a4
Cleanup
dandavison 7178c01
Test
dandavison a42fb44
Fix IncludeOutcome
dandavison c0ed2df
Test
dandavison 5bd95d7
Revert accidental change
dandavison ecf4139
Cleanup
dandavison 74e0a69
Update mock
dandavison e904d87
Rewrite chasm notifier
dandavison 5b8a8be
subscribe outside
dandavison 88e153d
Resubscribe
dandavison a500aa0
Fix mock
dandavison 23fe864
PS
dandavison 04a462d
Update test: becomes satisfied on 3rd state transition
dandavison e22f108
Fix test
dandavison ff48584
Increment in real Update
dandavison a84784c
DoAndReturn -> Return
dandavison 3485fb9
Return constant empty workflow data
dandavison 2f0b863
Times(1)
dandavison 0fe23be
Add missing mock call expectation
dandavison 8a410b6
Do Updates synchronously in main goroutine
dandavison 8e83fb0
Notify on both MS snapshot and mutation
dandavison d8d7721
Don't resubscribe unless necessary; code golf
dandavison 65b83a0
ungolf
dandavison 8dbd866
Cleanup
dandavison f34f222
- PS
dandavison 4146871
Partial revert 27aafa7cc2a91d8f24706b4ebf327b1d935a5f97
dandavison ddff1b5
Cleanup test
dandavison dc248f4
Delete cross-component polling tests
dandavison 1b46b23
Use testcore.RandomizeStr(t.Name())
dandavison c7f4ab0
Check RunID
dandavison 270c13b
code golf
dandavison fbc77f3
Revert "- PS"
dandavison e3d74a7
monotonicPredicateFn
dandavison 1f169fb
Tests
dandavison 2f10ee2
New deadline logic
dandavison 0dda6cc
Validation & error messages fixes
dandavison d3c709c
Fix CHASM not found errors
dandavison 1e5ca51
Test Outcome
dandavison 36fb610
Evove tests
dandavison e5d900b
Move StaleState test to unit tests
dandavison 07cc8cf
Rename
dandavison b7e5c98
Cleanup
dandavison 5cb1637
Revert addition of new metrics
dandavison 561b090
Subscribe does not return an error
dandavison 8087fa5
Fix memory leak
dandavison e4dd35d
Clean up, fix validation
dandavison 1e43970
Test absent RunID
dandavison 1ad72b5
Don't return unused ref
dandavison d19eee6
Complete activity implementation
fretz12 ccba5bc
Resolve remaining differences with poll-component
fretz12 bae540d
Addressed PR comments.
fretz12 de5e4f2
Terminate activity implementation
fretz12 83101fa
Remove last worker identity empty check.
fretz12 60edd4a
Remove save identity during terminate transition.
fretz12 ffc9d4b
Addressed PR comments.
fretz12 e2fa0a1
Revert lint auto fixes.
fretz12 a679842
Revert lint auto fixes.
fretz12 9bbad37
Revert lint auto fixes.
fretz12 b949d92
Merge remote-tracking branch 'origin/saa-complete-activity' into saa-…
fretz12 c0fe46c
Addressed PR comments.
fretz12 1ce503d
Merge standalone-activity.
fretz12 a16f89c
Regen mock
fretz12 485f461
Cleanup.
fretz12 957e570
Merge saa-complete-activity
fretz12 7ab31e1
Merge standalone-activity
fretz12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74 changes: 74 additions & 0 deletions
74
chasm/lib/activity/gen/activitypb/v1/request_response.go-helpers.pb.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
136 changes: 116 additions & 20 deletions
136
chasm/lib/activity/gen/activitypb/v1/request_response.pb.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.