Alias imports in activity.go #8859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fretz12
commented
Dec 17, 2025
chasm/lib/activity/activity.go
Outdated
| tokenspb "go.temporal.io/server/api/token/v1" | ||
| "go.temporal.io/server/chasm" | ||
| "go.temporal.io/server/chasm/lib/activity/gen/activitypb/v1" | ||
| statepb "go.temporal.io/server/chasm/lib/activity/gen/activitypb/v1" |
Contributor
Author
There was a problem hiding this comment.
open to a alternative alias
Contributor
There was a problem hiding this comment.
Other chasm libhraries use schedulerpb and callbackpb (although we alias that to callbackspb for some reason!).
I vote we alias the api one to apiactivitypb here for consistency with other CHASM libraries.
Contributor
Author
There was a problem hiding this comment.
That's what I tried first, but the linter is very insistent on calling the API one activitypb
Base automatically changed from
fredtzeng/saa-info-fields
to
standalone-activity
December 19, 2025 00:37
dandavison
pushed a commit
that referenced
this pull request
Dec 19, 2025
## What changed? Added alias to imports in activity.go ## Why? When `make lint-code` is run locally, it is insistent on aliasing the activity API import to `activitypb "go.temporal.io/api/activity/v1"`. This is because the activity model `"go.temporal.io/server/chasm/lib/activity/gen/activitypb/v1"` also has the name. I've renamed both so lint-code won't keep modifying it. ## How did you test it? - [X] built - [X] run locally and tested manually - [X] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added alias to imports in activity.go
Why?
When
make lint-codeis run locally, it is insistent on aliasing the activity API import toactivitypb "go.temporal.io/api/activity/v1". This is because the activity model"go.temporal.io/server/chasm/lib/activity/gen/activitypb/v1"also has the name. I've renamed both so lint-code won't keep modifying it.How did you test it?