Skip to content

Conversation

@dandavison
Copy link
Contributor

@dandavison dandavison commented Dec 18, 2025

What changed?

Cleaner implementation of logic involved when obtaining activity outcome for DescribeActivityExecution and PollActivityExecution.

Why?

Code cleanup. Suggested at #8771 (comment)

How did you test it?

  • built
  • covered by existing tests

Note

Streamlines outcome to return nil unless closed and consolidates failure resolution using last attempt details.

  • Activity execution outcome (chasm/lib/activity/activity.go):
    • Add closed-state guard in outcome to return nil unless lifecycle is closed.
    • Simplify outcome resolution: prefer Outcome.Successful/Outcome.Failed; otherwise fall back to LastAttempt.LastFailureDetails (removes status-based checks).

Written by Cursor Bugbot for commit 6674ea5. This will update automatically on new commits. Configure here.

@dandavison dandavison requested review from a team as code owners December 18, 2025 21:01
@dandavison dandavison merged commit 5770cf0 into standalone-activity Dec 18, 2025
56 of 59 checks passed
@dandavison dandavison deleted the saa-outcome-cleanup branch December 18, 2025 21:19
dandavison added a commit that referenced this pull request Dec 19, 2025
## What changed?
Cleaner implementation of logic involved when obtaining activity outcome
for `DescribeActivityExecution` and `PollActivityExecution`.

## Why?
Code cleanup. Suggested at
#8771 (comment)

## How did you test it?
- [x] built
- [x] covered by existing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants