Skip to content

Conversation

@rossnelson
Copy link
Collaborator

@rossnelson rossnelson commented Sep 5, 2025

Summary

Moves GitHub App authentication setup to the workflows themselves to ensure proper token usage throughout the entire workflow.

Problem

Push operations were failing with: "Required workflow 'Check for CODEOWNERS' is not satisfied"

The issue was that we need the GitHub App token from the very beginning of the workflow, including for the checkout step.

Solution

Following the pattern from temporal-worker-controller release workflow:

  • Generate GitHub App token as first step in dispatch workflows
  • Use token for checkout with fetch-depth: 0
  • Configure Git and gh CLI auth after checkout
  • Simplify commit-changes action to only handle commits

Testing

The changes will be validated when the next dispatch workflow runs after merging.

Jira

DT-3284

- Generate GitHub App token as first step in dispatch workflows
- Use token for checkout with fetch-depth: 0
- Configure Git and gh CLI auth after checkout
- Simplify commit-changes action to only handle commits
- Follows pattern from temporal-worker-controller release workflow

This ensures the GitHub App token is used throughout the entire
workflow, addressing repository rule violations for push operations.

Jira: DT-3284
@rossnelson rossnelson requested a review from a team as a code owner September 5, 2025 14:36
@rossnelson rossnelson requested review from GiantRobots and removed request for a team September 5, 2025 14:36
@rossnelson rossnelson merged commit 56a9ad8 into main Sep 5, 2025
7 checks passed
@rossnelson rossnelson deleted the dt-3284-fix-workflow-auth branch September 5, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants