DT-3150 - refactor paginated table to use <Table /> component
#2830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add deprecated comment to ApiPagination - change "fancy" prop to "primary"
…om what I can tell
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rossedfort
commented
Jul 25, 2025
laurakwhit
approved these changes
Jul 25, 2025
| @@ -1,3 +1,7 @@ | |||
| <!-- | |||
| @component ApiPagination | |||
| @deprecated This component is deprecated. Use `src/lib/holocene/table/paginated-table/api-paginated.svelte` instead. | |||
| export let updating = false; | ||
| export let maxHeight = ''; | ||
| export let fixed = false; | ||
| export let id: string = null; |
Collaborator
There was a problem hiding this comment.
Should we just extend the HTMLTableAttributes here instead of defining id?
Contributor
Author
There was a problem hiding this comment.
In this case maybe not the most useful, because this component is really only ever used when wrapped by src/lib/holocene/table/paginated-table/api-paginated.svelte or src/lib/holocene/table/paginated-table/paginated.svelte, and those components don't extended html table attributes. That said, they probably should. I've at least made the change to this component for now.
Alex-Tideman
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
<Table />component<Table />to support only adding a border when the table isn't wrapped by an element with a border<SkeletonTable /><ApiPagination />Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?