DT-3233 - add more language support to codeblock #2868
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You sure this passes accessibility? 
|
andrewzamojc
left a comment
andrewzamojc
left a comment
There was a problem hiding this comment.
Cool looking tabbed ui. I left a comment that suggests a change. Let me know what you think.
| bind:activeTab | ||
| content={hidden | ||
| ? content[activeTab] | ||
| : content[activeTab].replace('***', 'secret')} |
There was a problem hiding this comment.
Comment: Neat tabs. I like the simple interface.
| {/if} | ||
| </div> | ||
| </div> | ||
| {/if} |
There was a problem hiding this comment.
Possible change: Do the tabs and header actions play well with the maximizable and existing copy button? It seems kind of separate in the code and I can't quite do it in storybook. Ideally the tabs are maximizable too and the copy button isn't repeated.
There was a problem hiding this comment.
Good question, I didn't check on that behavior.
Good call, I didn't check |
- don't allow maximizable when tabs are used - switch string text back to primary
Description & motivation 💭
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?