Fix combobox test flakiness #2897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace getByRole with findByRole to properly wait for the listbox element to become visible after the CSS transition completes
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Fix the two remaining instances in Object Options and No Results tests
rossnelson
requested review from
andrewzamojc and
laurakwhit
and removed request for
rossedfort
laurakwhit
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The combobox tests were failing with "Unable to find an accessible element with the role 'listbox'" because they were using
getByRolewhich expects the element to be immediately visible. However, the Menu component applies CSS transitions (invisible scale-95 opacity-0) when closed, making the listbox technically present but not visible.Solution
Changed from
getByRole('listbox')tofindByRole('listbox')which waits for the element to become visible, accounting for the CSS transition timing.Test Plan
[ ] Run
pnpm stories:test- combobox tests should pass[ ] Verify Async Select test passes
[ ] Verify Multiselect test passes