Set day as max unit in formatDate and getDuration #2978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
laurakwhit
commented
Oct 23, 2025
| ? formatDistanceToNowStrict(parsed) + ` ${relativeLabel}` | ||
| : formatDistanceToNow(parsed) + ` ${relativeLabel}`; | ||
| return ( | ||
| formatDistanceToNowStrict(parsed, { |
Collaborator
Author
There was a problem hiding this comment.
Removed formatDistanceToNow here as it feels like we should probably just be using formatDistanceToNowStrict.
Unless there's some context as to why we were previously defaulting to formatDistanceToNow?
laurakwhit
force-pushed
the
DT-3349-use-days-default-relative-time-unit
branch
from
f069329 to
c3acd5a
Compare
laurakwhit
changed the title
Alex-Tideman
approved these changes
Oct 27, 2025
3 tasks
temporal-cicd bot
pushed a commit
that referenced
this pull request
Nov 4, 2025
Auto-generated version bump from 2.42.1 to 2.43.0 Bump type: minor Changes included: - [`c772936b`](c772936) add new logos (#2950) - [`e4659afc`](e4659af) Add TLS support for ui-server (#2745) - [`35333bc0`](35333bc) remove scroll up/down buttons in main content (#2975) - [`25f4cd50`](25f4cd5) Bump sveltekit-superforms from 2.27.1 to 2.27.4 (#2965) - [`133577d5`](133577d) Change sticky header to surface-background and include border (#2979) - [`c90bbe85`](c90bbe8) Add gradient for completed Activities with retries (#2977) - [`015de88a`](015de88) Set day as max unit in formatDate and getDuration (#2978) - [`edf98d97`](edf98d9) Allow custom keyword SAs to be quick filterable (#2980) - [`6183f331`](6183f33) Account for units less than a day in formatDate (#2982) - [`2688adac`](2688ada) Hide timeout if 0s (#2983) - [`7732e4b8`](7732e4b) feat(search-attributes): add disableTypeForExisting prop (#2984) - [`66a6323f`](66a6323) Fix holocene component prop types (#2985) - [`c8673e6c`](c8673e6) Fix handleFocusOut on maximize to allow highlighting text to copy (#2986) - [`547045af`](547045a) SVG loading (#2955) - [`ecacb1e0`](ecacb1e) fix(search-attributes): use $derived for reactive props pattern (#2992) - [`9f00bdf3`](9f00bdf) Use CurrentVersion createTime (#2995) - [`6bf4c09c`](6bf4c09) DT-2423 - move theme selector to user dropdown menu (#2988) - [`49746aba`](49746ab) DT-3415 - move data encoder settings for into a modal (#2981) - [`8046e1ac`](8046e1a) Add laptop-code and shield icons to Holocene icon system (#2997) - [`05d8686b`](05d8686) Add a slot to the bottom nav for user profile picture in cloud (#3004) - [`18d60d43`](18d60d4) Use page.data.namespace to access namespaceInfo (#3002) - [`2f24a1b5`](2f24a1b) Task Failure System View (#2991)
laurakwhit
added a commit
that referenced
this pull request
Nov 4, 2025
Auto-generated version bump from 2.42.1 to 2.43.0 Bump type: minor Changes included: - [`c772936b`](c772936) add new logos (#2950) - [`e4659afc`](e4659af) Add TLS support for ui-server (#2745) - [`35333bc0`](35333bc) remove scroll up/down buttons in main content (#2975) - [`25f4cd50`](25f4cd5) Bump sveltekit-superforms from 2.27.1 to 2.27.4 (#2965) - [`133577d5`](133577d) Change sticky header to surface-background and include border (#2979) - [`c90bbe85`](c90bbe8) Add gradient for completed Activities with retries (#2977) - [`015de88a`](015de88) Set day as max unit in formatDate and getDuration (#2978) - [`edf98d97`](edf98d9) Allow custom keyword SAs to be quick filterable (#2980) - [`6183f331`](6183f33) Account for units less than a day in formatDate (#2982) - [`2688adac`](2688ada) Hide timeout if 0s (#2983) - [`7732e4b8`](7732e4b) feat(search-attributes): add disableTypeForExisting prop (#2984) - [`66a6323f`](66a6323) Fix holocene component prop types (#2985) - [`c8673e6c`](c8673e6) Fix handleFocusOut on maximize to allow highlighting text to copy (#2986) - [`547045af`](547045a) SVG loading (#2955) - [`ecacb1e0`](ecacb1e) fix(search-attributes): use $derived for reactive props pattern (#2992) - [`9f00bdf3`](9f00bdf) Use CurrentVersion createTime (#2995) - [`6bf4c09c`](6bf4c09) DT-2423 - move theme selector to user dropdown menu (#2988) - [`49746aba`](49746ab) DT-3415 - move data encoder settings for into a modal (#2981) - [`8046e1ac`](8046e1a) Add laptop-code and shield icons to Holocene icon system (#2997) - [`05d8686b`](05d8686) Add a slot to the bottom nav for user profile picture in cloud (#3004) - [`18d60d43`](18d60d4) Use page.data.namespace to access namespaceInfo (#3002) - [`2f24a1b5`](2f24a1b) Task Failure System View (#2991) Co-authored-by: laurakwhit <15069288+laurakwhit@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Updates
formatDate(forrelativetime) andgetDurationto use days as the maximum unit unlessflexibleUnitsis true.Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
DT-3349Docs
Any docs updates needed?