Skip to content

Show error with filtering workflows #3011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laurakwhit merged 1 commit into from
Nov 7, 2025
Merged

Show error with filtering workflows #3011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 29 additions & 13 deletions src/lib/components/workflow/workflows-summary-configurable-table/table-empty-state.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
<script>
<script lang="ts">
import type { Snippet } from 'svelte';

import { page } from '$app/state';

import Alert from '$lib/holocene/alert.svelte';
Expand All @@ -13,6 +15,12 @@
import NoWorkflowTaskFailures from './empty-states/no-workflow-task-failures.svelte';
import NoWorkflows from './empty-states/no-workflows.svelte';

interface Props {
cloud?: Snippet;
}

let { cloud }: Props = $props();

let query = $derived(page.url.searchParams.get('query'));

let noResultsImages = $derived(
Expand Down Expand Up @@ -42,18 +50,26 @@
>
<div class="text-center">
<h2>
{hasTaskFailuresQuery
? translate(
'workflows.workflow-task-failures-query-empty-state-title',
)
: translate('workflows.workflow-query-empty-state-title')}
{#if $workflowError}
{translate('workflows.workflow-query-error-state')}
{:else}
{hasTaskFailuresQuery
? translate(
'workflows.workflow-task-failures-query-empty-state-title',
)
: translate('workflows.workflow-query-empty-state-title')}
{/if}
</h2>
<p class="text-secondary">
{hasTaskFailuresQuery
? translate(
'workflows.workflow-task-failures-query-empty-state-description',
)
: translate('workflows.workflow-query-empty-state-description')}
{#if $workflowError}
{$workflowError}
{:else}
{hasTaskFailuresQuery
? translate(
'workflows.workflow-task-failures-query-empty-state-description',
)
: translate('workflows.workflow-query-empty-state-description')}
{/if}
</p>
{#if hasTaskFailuresQuery}
<NoWorkflowTaskFailures class="m-auto mt-8 text-subtle" />
Expand All @@ -77,13 +93,13 @@
<Alert
intent="warning"
icon="warning"
title={translate('workflows.workflow-query-error-state')}
title={translate('common.error-occurred')}
style="overflow-wrap: anywhere"
>
{$workflowError}
</Alert>
{:else}
<slot name="cloud" />
{@render cloud?.()}
<p>
{translate('workflows.workflow-empty-state-description')}
<Link newTab href="https://github.com/temporalio"
Expand Down
2 changes: 1 addition & 1 deletion src/lib/i18n/locales/en/workflows.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ export const Strings = {
'No Task Failures Found. Nice Work!',
'workflow-task-failures-query-empty-state-description':
'None of your Workflows currently match your task failure criteria',
'workflow-query-error-state': 'There is an error with filtering Workflows.',
'workflow-query-error-state': 'Error Filtering Workflows',
'workflow-empty-state-title': 'No Workflows running in this Namespace',
'workflow-empty-state-description':
'You can populate the Web UI with sample Workflows. You can find a complete list of executable code samples at',
Expand Down
Loading