3592-Redesign of BSG sample app and port to React. #119
Open
3592-Redesign of BSG sample app and port to React. #119
Conversation
…its and misses to UI.
… Updates the UI to support this new pattern.
…helper functions.
…of graphic nodes draw on the canvas fo the battle grid.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pbienek
changed the title
CaisManai
suggested changes
Jul 24, 2024
CaisManai
left a comment
CaisManai
left a comment
There was a problem hiding this comment.
- Can we make the 'connect your wallet to the ten chain' more prominent. Else, when I land on the page and my wallet isn't connected, I'm mainly drawn to the 'SYSTEM OFFLINE' message and may just assume the game isn't currently working.
- Can we make the 'how to play?' more prominent too, particularly on your first go/first view
0xjba
approved these changes
Jul 25, 2024
Contributor
0xjba
left a comment
0xjba
left a comment
There was a problem hiding this comment.
Reviewed & tested the contract. GTG
0xjba
suggested changes
Jul 25, 2024
Contributor
0xjba
left a comment
0xjba
left a comment
There was a problem hiding this comment.
The frontend still needs the eth_chainId check to ensure users are on the TEN chain before they start playing. We've had instances where users were on Ethereum for the Guessing Game and lost money. When connecting the wallet, check for Chain ID 443. If not, prompt the user to add the TEN network via Gateway or switch to the TEN network.
# Conflicts: # battleship-game/contracts/BattleshipGame.sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the following link to view the latest deployment https://battleship-game-git-pete-3591-bsg-407e4f-tens-projects-c10453c0.vercel.app?_vercel_share=XllsfBwRkXoVKHP48jZSmtcTdHswqSVM