-
Notifications
You must be signed in to change notification settings - Fork 10
feat: add emit events and update spec docs #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add emit events and update spec docs #46
Conversation
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
+ Coverage 79.85% 80.54% +0.68%
==========================================
Files 12 12
Lines 283 293 +10
==========================================
+ Hits 226 236 +10
Misses 42 42
Partials 15 15
Continue to review full report at Codecov.
|
dongsam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested some lines, could you review the suggestions?
dongsam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: dongsam <dongsamb@gmail.com>
Co-authored-by: dongsam <dongsamb@gmail.com>
Description
closes: #38
Tasks
05_events.mdBefore we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Files changedin the Github PR explorerCodecov Reportin the comment section below once CI passes