fix contrast() #11219
Merged
fix contrast() #11219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mean pixel value should be weighted average of the histogram.
Collaborator
|
Hi @yeqingli, Could you please review this PR. Thank You |
yeqingli
reviewed
Oct 25, 2024
EIFY
added a commit
to EIFY/algorithmic-efficiency
that referenced
this pull request
Nov 28, 2024
See google-research/big_vision#109 Fix suggested by @yeqingli in tensorflow/models#11219 (review)
luotigerlsx
approved these changes
Jan 6, 2025
laxmareddyp
added
the
ready to pull
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
PiperOrigin-RevId: 712947091
EIFY
added a commit
to EIFY/algorithmic-efficiency
that referenced
this pull request
Jun 26, 2025
See google-research/big_vision#109 Fix suggested by @yeqingli in tensorflow/models#11219 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The mean pixel value should be weighted average of the histogram. google-research/big_vision and tensorflow/tpu have the same bug so ideally should be fixed in the same way.
Type of change
Tests
See google-research/big_vision#109 for details.
Checklist