-
Notifications
You must be signed in to change notification settings - Fork 2
Add typehints #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typehints #11
Conversation
|
Hi @seanmacavaney can you review? |
|
@cmacdonald @seanmacavaney can you review? |
|
Thanks for this, nice work. We should add a mypy GHA that verifies the types. Can you take a style.yml file from another of our projects? |
|
Added ruff config |
|
I tried to add |
|
Here is the mypy output: |
20fb907 to
5d763a7
Compare
|
added some comments - nearly there @Samoed ! |
|
Changed ruff to singe quotes |
|
LGTM. are you happy @seanmacavaney ? |
|
To avoid increasing the min supported python version, I switched to I think this is good to go, I'll merge and release. Thanks a bunch @Samoed! |
No description provided.